Ensure that instances of DisplayImpl and SurfaceImpl don't outlive SurfacesServiceApplication.

components/surfaces/surfaces_service_application.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/surfaces/surfaces_service_application.h"
 
+#include "base/stl_util.h"
 #include "components/surfaces/display_factory_impl.h"
 #include "components/surfaces/surfaces_impl.h"
 #include "components/surfaces/surfaces_scheduler.h"
 
 namespace surfaces {
 
 SurfacesServiceApplication::SurfacesServiceApplication()
     : next_id_namespace_(1u) {
 }
 
 SurfacesServiceApplication::~SurfacesServiceApplication() {
+  // Make a copy of the sets before deleting them because their destructor will
+  // call back into this class to remove them from the set.
+  auto displays = displays_;
+  STLDeleteElements(&displays_);

[Elliot Glaysher, 2015/05/18 17:41:29]

I suspect that autocomplete went out of control here. Drop the '_'?

[jam, 2015/05/18 17:44:20]

oops, fixed, thanks.

+  auto surfaces = surfaces_;
+  STLDeleteElements(&surfaces);
 }
 
 void SurfacesServiceApplication::Initialize(mojo::ApplicationImpl* app) {
   tracing_.Initialize(app);
   scheduler_.reset(new SurfacesScheduler);
 }
 
 bool SurfacesServiceApplication::ConfigureIncomingConnection(
     mojo::ApplicationConnection* connection) {
   connection->AddService<mojo::DisplayFactory>(this);
   connection->AddService<mojo::Surface>(this);
   return true;
 }
 
 void SurfacesServiceApplication::Create(
     mojo::ApplicationConnection* connection,
     mojo::InterfaceRequest<mojo::DisplayFactory> request) {
-  new DisplayFactoryImpl(&manager_, next_id_namespace_++, scheduler_.get(),
-                         request.Pass());
+  new DisplayFactoryImpl(this, &manager_, next_id_namespace_++,
+                         scheduler_.get(), request.Pass());
 }
 
 void SurfacesServiceApplication::Create(
     mojo::ApplicationConnection* connection,
     mojo::InterfaceRequest<mojo::Surface> request) {
-  new SurfacesImpl(&manager_, next_id_namespace_++, scheduler_.get(),
-                   request.Pass());
+  surfaces_.insert(
+      new SurfacesImpl(this, &manager_, next_id_namespace_++, scheduler_.get(),
+                       request.Pass()));
+}
+
+void SurfacesServiceApplication::DisplayCreated(DisplayImpl* display) {
+  displays_.insert(display);
+}
+
+void SurfacesServiceApplication::DisplayDestroyed(DisplayImpl* display) {
+  displays_.erase(display);
+}
+
+void SurfacesServiceApplication::SurfaceDestroyed(SurfacesImpl* surface) {
+  surfaces_.erase(surface);
 }
 
 }  // namespace surfaces