Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1131813002: Revert of Use Clang's update.py --print-revision everywhere. (Closed)

Created:
5 years, 7 months ago by Nico
Modified:
5 years, 7 months ago
Reviewers:
hans, scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use Clang's update.py --print-revision everywhere. (patchset #4 id:60001 of https://codereview.chromium.org/1127233002/) Reason for revert: Looks like this broke the world: http://build.chromium.org/p/chromium.fyi/console?category=win%20clang Original issue's description: > Use Clang's update.py --print-revision everywhere. > > Since yesterday, it works on Windows. This allows us to not > completely clobber the build from update.py each time, since the > build system tracks the dependency instead. > > It should also be possible to use this from gn, so we can delete the > posix-print-revision.py script. The only problem was that the > hack we use for fixing the output in gclient runhooks didn't work. > I've adjusted that to not fail when the hack doesn't work. > > BUG=483065 > > Committed: https://crrev.com/828bba82c5ed315cf073ad9599c0d5334a9a403d > Cr-Commit-Position: refs/heads/master@{#328634} TBR=scottmg@chromium.org,hans@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=483065 Committed: https://crrev.com/05320c6a7b8695c843c6d4de10261e7a65fafcb3 Cr-Commit-Position: refs/heads/master@{#328672}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -22 lines) Patch
M build/common.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +5 lines, -5 lines 0 comments Download
M build/download_gold_plugin.py View 1 chunk +3 lines, -3 lines 0 comments Download
A tools/clang/scripts/posix-print-revision.py View 1 chunk +11 lines, -0 lines 0 comments Download
M tools/clang/scripts/update.py View 4 chunks +15 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
Created Revert of Use Clang's update.py --print-revision everywhere.
5 years, 7 months ago (2015-05-07 01:14:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131813002/1
5 years, 7 months ago (2015-05-07 01:15:47 UTC) #2
hans
Thanks for watching the tree.
5 years, 7 months ago (2015-05-07 01:18:20 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-07 01:20:10 UTC) #4
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 01:21:02 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05320c6a7b8695c843c6d4de10261e7a65fafcb3
Cr-Commit-Position: refs/heads/master@{#328672}

Powered by Google App Engine
This is Rietveld 408576698