Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: build/config/compiler/BUILD.gn

Issue 1131813002: Revert of Use Clang's update.py --print-revision everywhere. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | build/download_gold_plugin.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 9ebb2e7b742ceeab320ee8f59206ce7f32146274..ad947050cc52f88c4b1ea2e465d326ba03d22364 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -158,15 +158,15 @@
]
}
- if (is_clang && !is_nacl) {
+ if (is_clang && !is_win && !is_nacl) {
# This is here so that all files get recompiled after a clang roll and
# when turning clang on or off. (defines are passed via the command line,
# and build system rebuild things when their commandline changes). Nothing
# should ever read this define.
- defines +=
- [ "CR_CLANG_REVISION=" + exec_script("//tools/clang/scripts/update.py",
- [ "--print-revision" ],
- "trim string") ]
+ defines += [ "CR_CLANG_REVISION=" +
+ exec_script("//tools/clang/scripts/posix-print-revision.py",
+ [],
+ "trim string") ]
}
# Mac-specific compiler flags setup.
« no previous file with comments | « build/common.gypi ('k') | build/download_gold_plugin.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698