build/common.gypi - Issue 1131813002: Revert of Use Clang's update.py --print-revision everywhere.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 1131813002: Revert of Use Clang's update.py --print-revision everywhere. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 23e1b443dbab683a92319e2e0af3f5278bc8de9e..1284360f9a3a8ba9fe69f8a79bcb1b70cad421db 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -2625,13 +2625,13 @@

}],

- ['clang==1 or host_clang==1', {

+ ['(clang==1 or host_clang==1) and OS!="win"', {

# This is here so that all files get recompiled after a clang roll and

# when turning clang on or off.

# (defines are passed via the command line, and build systems rebuild

# things when their commandline changes). Nothing should ever read this

# define.

- 'defines': ['CR_CLANG_REVISION=<!(python <(DEPTH)/tools/clang/scripts/update.py --print-revision)'],

+ 'defines': ['CR_CLANG_REVISION=<!(<(DEPTH)/tools/clang/scripts/update.sh --print-revision)'],

}],

['enable_rlz==1', {

'defines': ['ENABLE_RLZ'],

« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »