Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: components/network_hints/renderer/renderer_preconnect.h

Issue 1131293004: Add cross origin to Blink-driven preconnect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added test and switch to a boolean Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/network_hints/renderer/renderer_preconnect.h
diff --git a/components/network_hints/renderer/renderer_preconnect.h b/components/network_hints/renderer/renderer_preconnect.h
index adc014339fadd5f1fb3c196819c42ea0f8aced19..96e81d3696ba4604edca37d60841761bd7768460 100644
--- a/components/network_hints/renderer/renderer_preconnect.h
+++ b/components/network_hints/renderer/renderer_preconnect.h
@@ -17,6 +17,7 @@
#ifndef COMPONENTS_NETWORK_HINTS_RENDERER_RENDERER_PRECONNECT_H_
#define COMPONENTS_NETWORK_HINTS_RENDERER_RENDERER_PRECONNECT_H_
+#include "third_party/WebKit/public/platform/WebCrossOriginAttribute.h"
#include "url/gurl.h"
namespace network_hints {
@@ -29,7 +30,7 @@ class RendererPreconnect {
~RendererPreconnect();
// Submit a preconnect request for a single connection.
- void Preconnect(const GURL &url);
+ void Preconnect(const GURL &url, blink::CrossOriginAttributeValue);
Ryan Sleevi 2015/06/10 19:30:42 You shouldn't be depending on blink from component
Ryan Sleevi 2015/06/11 18:30:09 Yoav wrote:
Ryan Sleevi 2015/06/11 18:33:12 Just to be clear, this is the least of the concern
private:

Powered by Google App Engine
This is Rietveld 408576698