Add cross origin to Blink-driven preconnect

components/network_hints/renderer/renderer_preconnect.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // A RendererPreconnect instance is maintained for each RenderThread.
 // URL strings are typically added to the embedded queue during rendering.
 // The first addition to the queue (transitioning from empty to having
 // some names) causes a processing task to be added to the Renderer Thread.
 // The processing task gathers all buffered URLs, and send them via IPC
 // to the browser.
 // This class counts repeated requests for the same URL and requests that
 // number of connections be preconnected. If multiple requests are sent
 // separately the net stack will just keep re-using the first pending
 // connection so we allow for the time between the parsing of the tags and
 // when the task is scheduled to accumulate multiple requests.
 
 #ifndef COMPONENTS_NETWORK_HINTS_RENDERER_RENDERER_PRECONNECT_H_
 #define COMPONENTS_NETWORK_HINTS_RENDERER_RENDERER_PRECONNECT_H_
 
+#include "third_party/WebKit/public/platform/WebCrossOriginAttribute.h"
 #include "url/gurl.h"
 
 namespace network_hints {
 
 // An internal interface to the network_hints component for efficiently sending
 // DNS prefetch requests to the net stack.

[Ryan Sleevi, 2015/06/10 19:30:42]

This comment seems out of date :)

 class RendererPreconnect {
  public:
   RendererPreconnect();
   ~RendererPreconnect();
 
   // Submit a preconnect request for a single connection.
-  void Preconnect(const GURL &url);
+  void Preconnect(const GURL &url, blink::CrossOriginAttributeValue);

[Ryan Sleevi, 2015/06/10 19:30:42]

You shouldn't be depending on blink from components like this, AFAICT

[Ryan Sleevi, 2015/06/11 18:30:09]

Yoav wrote:
It looks like this was done in
https://chromium.googlesource.com/chromium/src/+/e49c69208e7da19a0b2a3ac9f2fd...
, and that should have been flagged then.

Just because someone else is doing it doesn't make it right :/

[Ryan Sleevi, 2015/06/11 18:33:12]

Just to be clear, this is the least of the concerns with the CL.

 
  private:
 
   DISALLOW_COPY_AND_ASSIGN(RendererPreconnect);
 };  // class RendererPreconnect
 
 }  // namespace network_hints
 
 #endif  // COMPONENTS_NETWORK_HINTS_RENDERER_RENDERER_PRECONNECT_H_