components/network_hints/renderer/prescient_networking_dispatcher.cc - Issue 1131293004: Add cross origin to Blink-driven preconnect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/network_hints/renderer/prescient_networking_dispatcher.cc

Issue 1131293004: Add cross origin to Blink-driven preconnect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added test and switch to a boolean Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/network_hints/common/network_hints_messages.h ('K') | « components/network_hints/renderer/prescient_networking_dispatcher.h ('k') | components/network_hints/renderer/renderer_preconnect.h » ('j') | components/network_hints/renderer/renderer_preconnect.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/network_hints/renderer/prescient_networking_dispatcher.cc

diff --git a/components/network_hints/renderer/prescient_networking_dispatcher.cc b/components/network_hints/renderer/prescient_networking_dispatcher.cc

index a5599c99b0aa80209042a3d7a35516e155ab386d..aae53acb52e089e36a1cecc728d696dd2c9c1b4c 100644

--- a/components/network_hints/renderer/prescient_networking_dispatcher.cc

+++ b/components/network_hints/renderer/prescient_networking_dispatcher.cc

@@ -26,7 +26,13 @@ void PrescientNetworkingDispatcher::prefetchDNS(

void PrescientNetworkingDispatcher::preconnect(const blink::WebURL& url) {

VLOG(2) << "Preconnect: " << url.string().utf8();

- preconnect_.Preconnect(url);

+ preconnect_.Preconnect(url, blink::CrossOriginAttributeNotSet);

+void PrescientNetworkingDispatcher::preconnect(const blink::WebURL& url,

+ const blink::CrossOriginAttributeValue crossOrigin) {

+ VLOG(2) << "Preconnect: " << url.string().utf8();

+ preconnect_.Preconnect(url, crossOrigin);

}

} // namespace network_hints