Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1131263009: Oilpan: fix build after r195134. (Closed)

Created:
5 years, 7 months ago by sof
Modified:
5 years, 7 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, caseq+blink_chromium.org, arv+blink, vivekg_samsung, vivekg, yurys+blink_chromium.org, lushnikov+blink_chromium.org, loislo+blink_chromium.org, pfeldman+blink_chromium.org, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: fix build after r195134. TBR=oilpan-reviews BUG=466631 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195142

Patch Set 1 #

Patch Set 2 : fix transition type (oilpan only change) #

Patch Set 3 : disable trace() impl, non-Oilpan #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -17 lines) Patch
M Source/bindings/core/v8/PageScriptDebugServer.h View 3 chunks +11 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/PageScriptDebugServer.cpp View 1 2 2 chunks +12 lines, -1 line 1 comment Download
M Source/bindings/core/v8/ScriptDebugServer.h View 3 chunks +15 lines, -6 lines 0 comments Download
M Source/bindings/core/v8/WorkerScriptDebugServer.h View 1 chunk +8 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/WorkerScriptDebugServer.cpp View 1 chunk +12 lines, -2 lines 0 comments Download
M Source/core/inspector/PerIsolateDebuggerClient.h View 1 chunk +6 lines, -2 lines 0 comments Download
M Source/core/inspector/PerIsolateDebuggerClient.cpp View 1 2 chunks +7 lines, -1 line 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
please take a look. Somewhat unfortunate that no one on the Oilpan team had an ...
5 years, 7 months ago (2015-05-09 08:29:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131263009/40001
5 years, 7 months ago (2015-05-09 08:30:01 UTC) #3
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=195142
5 years, 7 months ago (2015-05-09 08:34:04 UTC) #4
haraken
5 years, 7 months ago (2015-05-09 14:37:28 UTC) #6
Message was sent while issue was closed. 
LGTM as a build fix of oilpan.

https://codereview.chromium.org/1131263009/diff/40001/Source/bindings/core/v8...
File Source/bindings/core/v8/PageScriptDebugServer.cpp (right):

https://codereview.chromium.org/1131263009/diff/40001/Source/bindings/core/v8...
Source/bindings/core/v8/PageScriptDebugServer.cpp:64: PageScriptDebugServer*
PageScriptDebugServer::s_instance = nullptr;

This looks nasty, not only in oilpan but also in non-oilpan. Can we probably
instantiate the instance using DEFINE_STATIC_LOCAL?

Powered by Google App Engine
This is Rietveld 408576698