Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: Source/bindings/core/v8/ScriptDebugServer.h

Issue 1131263009: Oilpan: fix build after r195134. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: disable trace() impl, non-Oilpan Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/ScriptDebugServer.h
diff --git a/Source/bindings/core/v8/ScriptDebugServer.h b/Source/bindings/core/v8/ScriptDebugServer.h
index 588546f0abf5a623d617d0cd24346e5f65c01408..6fea1b1013993d83bb9640095aade01b6c2af5fe 100644
--- a/Source/bindings/core/v8/ScriptDebugServer.h
+++ b/Source/bindings/core/v8/ScriptDebugServer.h
@@ -35,7 +35,8 @@
#include "core/InspectorTypeBuilder.h"
#include "core/inspector/ScriptBreakpoint.h"
#include "core/inspector/ScriptDebugListener.h"
-#include "wtf/PassOwnPtr.h"
+#include "platform/heap/Handle.h"
+#include "wtf/Forward.h"
#include <v8-debug.h>
#include <v8.h>
@@ -50,18 +51,25 @@ class JavaScriptCallFrame;
class CORE_EXPORT ScriptDebugServer : public NoBaseWillBeGarbageCollectedFinalized<ScriptDebugServer> {
WTF_MAKE_NONCOPYABLE(ScriptDebugServer);
public:
- virtual ~ScriptDebugServer();
- DECLARE_VIRTUAL_TRACE();
-
- class Client {
+ class Client : public WillBeGarbageCollectedMixin {
public:
virtual ~Client() { }
virtual v8::Local<v8::Object> compileDebuggerScript() = 0;
virtual ScriptDebugListener* getDebugListenerForContext(v8::Local<v8::Context>) = 0;
virtual void runMessageLoopOnPause(v8::Local<v8::Context>) = 0;
virtual void quitMessageLoopOnPause() = 0;
+
+ DEFINE_INLINE_VIRTUAL_TRACE() { }
};
+ static PassOwnPtrWillBeRawPtr<ScriptDebugServer> create(v8::Isolate* isolate, Client* client)
+ {
+ return adoptPtrWillBeNoop(new ScriptDebugServer(isolate, client));
+ }
+
+ virtual ~ScriptDebugServer();
+ DECLARE_VIRTUAL_TRACE();
+
void enable();
void disable();
bool enabled() const;
@@ -121,9 +129,10 @@ public:
v8::MaybeLocal<v8::Value> setFunctionVariableValue(v8::Local<v8::Value> functionValue, int scopeNumber, const String& variableName, v8::Local<v8::Value> newValue);
v8::Isolate* isolate() const { return m_isolate; }
- explicit ScriptDebugServer(v8::Isolate*, Client*);
private:
+ ScriptDebugServer(v8::Isolate*, Client*);
+
void compileDebuggerScript();
v8::MaybeLocal<v8::Value> callDebuggerMethod(const char* functionName, int argc, v8::Local<v8::Value> argv[]);
v8::Local<v8::Object> debuggerScriptLocal() const;

Powered by Google App Engine
This is Rietveld 408576698