Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: Source/bindings/core/v8/PageScriptDebugServer.h

Issue 1131263009: Oilpan: fix build after r195134. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: disable trace() impl, non-Oilpan Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/PageScriptDebugServer.h
diff --git a/Source/bindings/core/v8/PageScriptDebugServer.h b/Source/bindings/core/v8/PageScriptDebugServer.h
index f8e220a99580f5f7d2a797723a8810a036bc190f..57aec097b2f3fab947f9768d7ba4ee5ca76ffb73 100644
--- a/Source/bindings/core/v8/PageScriptDebugServer.h
+++ b/Source/bindings/core/v8/PageScriptDebugServer.h
@@ -43,8 +43,9 @@ namespace blink {
class Page;
-class CORE_EXPORT PageScriptDebugServer final : public PerIsolateDebuggerClient {
+class CORE_EXPORT PageScriptDebugServer final : public NoBaseWillBeGarbageCollectedFinalized<PageScriptDebugServer>, public PerIsolateDebuggerClient {
WTF_MAKE_NONCOPYABLE(PageScriptDebugServer);
+ WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(PageScriptDebugServer);
public:
class ClientMessageLoop {
public:
@@ -53,7 +54,11 @@ public:
virtual void quitNow() = 0;
};
- PageScriptDebugServer(PassOwnPtr<ClientMessageLoop>, v8::Isolate*);
+ static PassOwnPtrWillBeRawPtr<PageScriptDebugServer> create(PassOwnPtr<ClientMessageLoop> clientMessageLoop, v8::Isolate* isolate)
+ {
+ return adoptPtrWillBeNoop(new PageScriptDebugServer(clientMessageLoop, isolate));
+ }
+
~PageScriptDebugServer() override;
static void setContextDebugData(v8::Local<v8::Context>, const String& type, int contextDebugId);
@@ -63,7 +68,11 @@ public:
static PageScriptDebugServer* instance();
static void interruptMainThreadAndRun(PassOwnPtr<ScriptDebugServer::Task>);
+ DECLARE_VIRTUAL_TRACE();
+
private:
+ PageScriptDebugServer(PassOwnPtr<ClientMessageLoop>, v8::Isolate*);
+
ScriptDebugListener* getDebugListenerForContext(v8::Local<v8::Context>) override;
void runMessageLoopOnPause(v8::Local<v8::Context>) override;
void quitMessageLoopOnPause() override;
« no previous file with comments | « no previous file | Source/bindings/core/v8/PageScriptDebugServer.cpp » ('j') | Source/bindings/core/v8/PageScriptDebugServer.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698