Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11312203: "Reverting 14829-14832" (Closed)

Created:
8 years, 1 month ago by Anders Johnsen
Modified:
8 years, 1 month ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

"Reverting 14829-14832" BUG= Committed: https://code.google.com/p/dart/source/detail?r=14833

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+289 lines, -290 lines) Patch
M pkg/args/lib/args.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/args/test/args_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/http/lib/src/utils.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/intl/lib/bidi_utils.dart View 13 chunks +17 lines, -17 lines 0 comments Download
M pkg/intl/lib/date_format.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/intl/lib/intl_standalone.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/intl/lib/src/date_format_helpers.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/unittest/lib/html_layout_config.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/unittest/lib/interactive_html_config.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/unittest/lib/src/config.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/webdriver/lib/webdriver.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/regexp_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/markdown/block_parser.dart View 1 chunk +9 lines, -9 lines 0 comments Download
M samples/markdown/html_renderer.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/swarm/swarm_ui_lib/base/Device.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/js/printer.dart View 3 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/coreimpl_patch.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/string_helper.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/native_handler.dart View 2 chunks +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/variable_allocator.dart View 2 chunks +1 line, -1 line 0 comments Download
M sdk/lib/_internal/dartdoc/lib/dartdoc.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/dartdoc/lib/src/markdown/block_parser.dart View 1 chunk +9 lines, -9 lines 0 comments Download
M sdk/lib/_internal/dartdoc/lib/src/markdown/html_renderer.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/date.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/regexp.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/coreimpl/regexp.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/html/src/shared_SVGFactoryProviders.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/templates/html/impl/impl_Document.darttemplate View 2 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/html/templates/html/impl/impl_Element.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/uri/uri.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/test_config.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/boolified_operator_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/class_codegen2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/class_order_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/closure_codegen_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/code_motion_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/constant_folding_test.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/dead_phi_eliminator_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/gvn_dynamic_field_get_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/gvn_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/identity_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/minify_many_locals_test.dart View 1 chunk +7 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/pretty_parameter_test.dart View 1 chunk +11 lines, -11 lines 0 comments Download
M tests/compiler/dart2js/redundant_phi_eliminator_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/rewrite_better_user_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_guard_unuser_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_inference5_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_inference_test.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/value_range_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/corelib/reg_exp1_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/corelib/reg_exp4_test.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M tests/corelib/string_split_reg_exp_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/language/reg_exp_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/release/version.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/multitest.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/status_expression.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M tools/testing/dart/status_file_parser.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 chunk +13 lines, -13 lines 0 comments Download
M utils/apidoc/apidoc.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/apidoc/html_diff.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/apidoc/mdn/extract.dart View 4 chunks +8 lines, -8 lines 0 comments Download
M utils/pub/git_source.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/io.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/pub/version.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/pub/yaml/composer.dart View 5 chunks +8 lines, -8 lines 0 comments Download
M utils/pub/yaml/model.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/template/codegen.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/testrunner/layout_test_controller.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/tests/pub/install/git/check_out_and_update_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/tests/pub/install/git/check_out_branch_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/install/git/check_out_revision_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/install/git/check_out_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/install/git/check_out_transitive_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/install/git/check_out_twice_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/tests/pub/install/git/check_out_with_trailing_slash_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/install/git/dependency_name_match_pubspec_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/install/git/different_repo_name_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/install/git/lock_version_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/tests/pub/install/git/require_pubspec_name_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/install/git/require_pubspec_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/install/git/stay_locked_if_compatible_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/tests/pub/install/git/unlock_if_incompatible_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/tests/pub/install/hosted/check_out_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/install/hosted/check_out_transitive_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/install/hosted/do_not_update_on_removed_constraints_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/tests/pub/install/hosted/fail_gracefully_on_missing_package_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/install/hosted/fail_gracefully_on_url_resolve_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/install/hosted/remove_removed_dependency_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/tests/pub/install/hosted/remove_removed_transitive_dependency_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/tests/pub/install/hosted/resolve_constraints_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/install/hosted/stay_locked_if_compatible_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/tests/pub/install/hosted/stay_locked_if_new_is_satisfied_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/tests/pub/install/hosted/stay_locked_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/tests/pub/install/hosted/unlock_if_incompatible_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/tests/pub/install/hosted/unlock_if_new_is_unsatisfied_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/tests/pub/install/pub_install_test.dart View 12 chunks +13 lines, -13 lines 0 comments Download
M utils/tests/pub/install/sdk/check_out_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/install/sdk/check_out_transitive_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/test_pub.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/update/git/do_not_update_if_unneeded_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/tests/pub/update/git/update_locked_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/tests/pub/update/git/update_one_locked_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/tests/pub/update/git/update_to_incompatible_pubspec_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/tests/pub/update/git/update_to_nonexistent_pubspec_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/tests/pub/update/hosted/fail_gracefully_on_missing_package_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/update/hosted/fail_gracefully_on_url_resolve_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/update/hosted/remove_removed_dependency_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/tests/pub/update/hosted/remove_removed_transitive_dependency_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/tests/pub/update/hosted/unlock_dependers_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/tests/pub/update/hosted/unlock_if_necessary_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/tests/pub/update/hosted/update_removed_constraints_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/tests/pub/update/pub_update_test.dart View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Anders Johnsen
TBR
8 years, 1 month ago (2012-11-13 07:28:07 UTC) #1
ricow1
8 years, 1 month ago (2012-11-13 07:31:23 UTC) #2 
Rubberstamp LGTM

Powered by Google App Engine
This is Rietveld 408576698