"Reverting 14829-14832"

pkg/args/test/args_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library args_test;
 
 import '../../../pkg/unittest/lib/unittest.dart';
 
 // TODO(rnystrom): Use "package:" URL here when test.dart can handle pub.
 import '../lib/args.dart';
@@ skipping 663 matching lines @@
 validateUsage(ArgParser parser, String expected) {
   expected = unindentString(expected);
   expect(parser.getUsage(), equals(expected));
 }
 
 // TODO(rnystrom): Replace one in test_utils.
 String unindentString(String text) {
   var lines = text.split('\n');
 
   // Count the indentation of the last line.
-  var whitespace = new RegExp('^ *');
+  var whitespace = const RegExp('^ *');
   var indent = whitespace.firstMatch(lines[lines.length - 1])[0].length;
 
   // Drop the last line. It only exists for specifying indentation.
   lines.removeLast();
 
   // Strip indentation from the remaining lines.
   for (var i = 0; i < lines.length; i++) {
     var line = lines[i];
     if (line.length <= indent) {
       // It's short, so it must be nothing but whitespace.
       if (line.trim() != '') {
         throw new ArgumentError(
             'Line "$line" does not have enough indentation.');
       }
 
       lines[i] = '';
     } else {
       if (line.substring(0, indent).trim() != '') {
         throw new ArgumentError(
             'Line "$line" does not have enough indentation.');
       }
 
       lines[i] = line.substring(indent);
     }
   }
 
   return Strings.join(lines, '\n');
 }