Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 11312203: "Reverting 14829-14832" (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/status_file_parser.dart ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 758d91080e5846b181084827c54134b5200e759e..7f88becee9db5218beb79e3b0270647a1d791324 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -1153,7 +1153,7 @@ class ProcessQueue {
stdoutStringStream.onLine = () {
var line = stdoutStringStream.readLine();
while (null != line) {
- var regexp = new RegExp(r".*selenium-server-standalone.*");
+ var regexp = const RegExp(r".*selenium-server-standalone.*");
if (regexp.hasMatch(line)) {
_seleniumAlreadyRunning = true;
resumeTesting();
@@ -1196,8 +1196,8 @@ class ProcessQueue {
if (source.closed) return; // TODO(whesse): Remove when bug is fixed.
var line = source.readLine();
while (null != line) {
- if (new RegExp(r".*Started.*Server.*").hasMatch(line) ||
- new RegExp(r"Exception.*Selenium is already running.*").hasMatch(
+ if (const RegExp(r".*Started.*Server.*").hasMatch(line) ||
+ const RegExp(r"Exception.*Selenium is already running.*").hasMatch(
line)) {
resumeTesting();
}
@@ -1219,7 +1219,7 @@ class ProcessQueue {
filePath = '${filePath.substring(0, index)}${pathSep}testing${pathSep}';
var lister = new Directory(filePath).list();
lister.onFile = (String file) {
- if (new RegExp(r"selenium-server-standalone-.*\.jar").hasMatch(file)
+ if (const RegExp(r"selenium-server-standalone-.*\.jar").hasMatch(file)
&& _seleniumServer == null) {
Future processFuture = Process.start('java', ['-jar', file]);
processFuture.then((Process server) {
« no previous file with comments | « tools/testing/dart/status_file_parser.dart ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698