Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1131143002: Angular workarounds (Closed)

Created:
5 years, 7 months ago by vsm
Modified:
5 years, 7 months ago
Reviewers:
Leaf, Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Angular workarounds - Workaround for symbolized methods (e.g., core.$map) - dload/dput workarounds - NSM workaround - generic method type check workarounds R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/0ece9339be49249478cbf33a7bbcbe0129e14890

Patch Set 1 #

Patch Set 2 : Revert message_widget #

Patch Set 3 : Revert library rename hack #

Patch Set 4 : Cleanup and test rebase #

Patch Set 5 : Cleanup workaround for extension methods #

Patch Set 6 : Cleanup, update comments, remove dead code #

Patch Set 7 : More dart_runtime.js cleanup #

Patch Set 8 : Revert int-double changes #

Patch Set 9 : Core lib workaround #

Patch Set 10 : Cleanup isolate code #

Patch Set 11 : Some more cleanup #

Patch Set 12 : Rebase on latest #

Total comments: 2

Patch Set 13 : Rebase onto latest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -178 lines) Patch
M lib/runtime/dart/_interceptors.js View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +6 lines, -6 lines 0 comments Download
M lib/runtime/dart/_isolate_helper.js View 1 2 3 4 5 6 7 8 9 10 11 4 chunks +6 lines, -6 lines 0 comments Download
M lib/runtime/dart/_js_helper.js View 1 2 3 4 5 6 7 8 9 10 11 10 chunks +13 lines, -24 lines 0 comments Download
M lib/runtime/dart/convert.js View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart/core.js View 1 2 3 4 5 6 7 8 9 10 11 12 9 chunks +11 lines, -15 lines 0 comments Download
M lib/runtime/dart/math.js View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +5 lines, -5 lines 0 comments Download
M lib/runtime/dart_runtime.js View 1 2 3 4 5 6 7 8 9 10 11 12 8 chunks +121 lines, -10 lines 0 comments Download
M lib/src/codegen/html_codegen.dart View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +3 lines, -1 line 0 comments Download
M lib/src/codegen/js_codegen.dart View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -9 lines 0 comments Download
M test/codegen/expect/html_input.html View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/sunflower/sunflower.html View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download
M test/dart_codegen/expect/core/list.dart View 1 2 3 4 5 6 7 8 3 chunks +7 lines, -10 lines 0 comments Download
M test/dart_codegen/expect/core/stopwatch.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/dart_codegen/expect/core/uri.dart View 1 2 3 9 chunks +14 lines, -14 lines 0 comments Download
M test/generated_sdk/lib/_internal/compiler/js_lib/isolate_helper.dart View 1 2 3 4 5 6 7 8 9 10 3 chunks +13 lines, -5 lines 0 comments Download
M test/generated_sdk/lib/_internal/compiler/js_lib/js_helper.dart View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +8 lines, -23 lines 0 comments Download
M test/generated_sdk/lib/core/function.dart View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -3 lines 0 comments Download
M test/generated_sdk/lib/core/list.dart View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +4 lines, -6 lines 0 comments Download
M tool/input_sdk/lib/core/list.dart View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -5 lines 0 comments Download
M tool/input_sdk/patch/core_patch.dart View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +4 lines, -4 lines 0 comments Download
M tool/input_sdk/private/isolate_helper.dart View 1 2 3 4 5 6 7 8 9 10 3 chunks +13 lines, -5 lines 0 comments Download
M tool/input_sdk/private/js_helper.dart View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +8 lines, -23 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
vsm
This is just for reference / discussion. Not for review or landing. Angular2's hello app ...
5 years, 7 months ago (2015-05-11 18:27:42 UTC) #2
Jennifer Messerly
a lot of this looks good ... what are steps for landing?
5 years, 7 months ago (2015-05-13 23:25:00 UTC) #3
vsm
On 2015/05/13 23:25:00, John Messerly wrote: > a lot of this looks good ... what ...
5 years, 7 months ago (2015-05-14 13:17:11 UTC) #4
Jennifer Messerly
On 2015/05/14 13:17:11, vsm wrote: > On 2015/05/13 23:25:00, John Messerly wrote: > > a ...
5 years, 7 months ago (2015-05-14 14:44:00 UTC) #5
vsm
On 2015/05/14 14:44:00, John Messerly wrote: > On 2015/05/14 13:17:11, vsm wrote: > > On ...
5 years, 7 months ago (2015-05-14 16:54:57 UTC) #6
Jennifer Messerly
lgtm https://codereview.chromium.org/1131143002/diff/210001/lib/runtime/dart_runtime.js File lib/runtime/dart_runtime.js (right): https://codereview.chromium.org/1131143002/diff/210001/lib/runtime/dart_runtime.js#newcode953 lib/runtime/dart_runtime.js:953: // Note, we generate code of the form: ...
5 years, 7 months ago (2015-05-14 18:34:17 UTC) #7
vsm
5 years, 7 months ago (2015-05-14 19:47:44 UTC) #8
Message was sent while issue was closed.
Committed patchset #13 (id:230001) manually as
0ece9339be49249478cbf33a7bbcbe0129e14890 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698