Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: tool/input_sdk/lib/core/list.dart

Issue 1131143002: Angular workarounds (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master
Patch Set: Rebase onto latest Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/generated_sdk/lib/core/list.dart ('k') | tool/input_sdk/patch/core_patch.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tool/input_sdk/lib/core/list.dart
diff --git a/tool/input_sdk/lib/core/list.dart b/tool/input_sdk/lib/core/list.dart
index 20dce08cca7921258acd443037173e658c8924e4..a771976a91565c3526cacd367e46327437b05021 100644
--- a/tool/input_sdk/lib/core/list.dart
+++ b/tool/input_sdk/lib/core/list.dart
@@ -243,11 +243,9 @@ abstract class List<E> implements Iterable<E>, EfficientLength {
String toString() => ListBase.listToString(this);
List<E> toList({ bool growable: true }) {
- if (growable) {
- return new JSArray<E>.markGrowable(JS('', '#.slice()', this));
- } else {
- return new JSArray<E>.markFixed(JS('', '#.slice()', this));
- }
+ // TODO(vsm): Enforce growable / non-growable.
+ // See: https://github.com/dart-lang/dev_compiler/issues/175
+ return JS('', 'dart.setType(#.slice(), core.List\$(#))', this, E);
}
Set<E> toSet() => new Set<E>.from(this);
« no previous file with comments | « test/generated_sdk/lib/core/list.dart ('k') | tool/input_sdk/patch/core_patch.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698