Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1882)

Unified Diff: tool/input_sdk/patch/core_patch.dart

Issue 1131143002: Angular workarounds (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master
Patch Set: Rebase onto latest Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tool/input_sdk/lib/core/list.dart ('k') | tool/input_sdk/private/isolate_helper.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tool/input_sdk/patch/core_patch.dart
diff --git a/tool/input_sdk/patch/core_patch.dart b/tool/input_sdk/patch/core_patch.dart
index dfb6ac0a12335dc8f9a0a653b4a926b78e277424..855a3831b339497b266b651756aaa6e655ba0da7 100644
--- a/tool/input_sdk/patch/core_patch.dart
+++ b/tool/input_sdk/patch/core_patch.dart
@@ -64,9 +64,9 @@ class Function {
static apply(Function f,
List positionalArguments,
[Map<Symbol, dynamic> namedArguments]) {
- return Primitives.applyFunction(
- f, positionalArguments,
- namedArguments == null ? null : _toMangledNames(namedArguments));
+ // TODO(vsm): Handle named args.
+ // See: https://github.com/dart-lang/dev_compiler/issues/176
+ return JS('', 'dart.dcall.apply(null, [#].concat(#))', f, positionalArguments);
}
static Map<String, dynamic> _toMangledNames(
@@ -280,7 +280,7 @@ class List<E> {
@patch
factory List.from(Iterable elements, { bool growable: true }) {
List<E> list = new List<E>();
- for (E e in elements) {
+ for (var e in elements) {
list.add(e);
}
if (growable) return list;
« no previous file with comments | « tool/input_sdk/lib/core/list.dart ('k') | tool/input_sdk/private/isolate_helper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698