extensions/common/permissions/manifest_permission.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/permissions/manifest_permission.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/value_store/value_store_unittest.cc ('k') | extensions/common/permissions/set_disjunction_permission.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/permissions/manifest_permission.cc

diff --git a/extensions/common/permissions/manifest_permission.cc b/extensions/common/permissions/manifest_permission.cc

index a3a3a0914a4eb62a38fb21ddf73a28f1acb93b3d..6be6b188a08ba60bf45c8b1054b9dfc603add43e 100644

--- a/extensions/common/permissions/manifest_permission.cc

+++ b/extensions/common/permissions/manifest_permission.cc

@@ -48,7 +48,7 @@ bool ManifestPermission::Read(const IPC::Message* m, PickleIterator* iter) {

void ManifestPermission::Log(std::string* log) const {

base::JSONWriter::WriteWithOptions(

- ToValue().get(), base::JSONWriter::OPTIONS_PRETTY_PRINT, log);

+ *ToValue(), base::JSONWriter::OPTIONS_PRETTY_PRINT, log);

}

} // namespace extensions