extensions/common/permissions/manifest_permission.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/common/permissions/manifest_permission.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "extensions/common/permissions/manifest_permission.h"	5 #include "extensions/common/permissions/manifest_permission.h"

6	6

7 #include "base/json/json_writer.h"	7 #include "base/json/json_writer.h"

8 #include "extensions/common/manifest_handler.h"	8 #include "extensions/common/manifest_handler.h"

9 #include "ipc/ipc_message.h"	9 #include "ipc/ipc_message.h"

10 #include "ipc/ipc_message_utils.h"	10 #include "ipc/ipc_message_utils.h"

(...skipping 30 matching lines...) Expand all Loading...
41 if (singleton.GetSize() != 1)	41 if (singleton.GetSize() != 1)

42 return false;	42 return false;

43 base::Value* value = NULL;	43 base::Value* value = NULL;

44 if (!singleton.Get(0, &value))	44 if (!singleton.Get(0, &value))

45 return false;	45 return false;

46 return FromValue(value);	46 return FromValue(value);

47 }	47 }

48	48

49 void ManifestPermission::Log(std::string* log) const {	49 void ManifestPermission::Log(std::string* log) const {

50 base::JSONWriter::WriteWithOptions(	50 base::JSONWriter::WriteWithOptions(

51 ToValue().get(), base::JSONWriter::OPTIONS_PRETTY_PRINT, log);	51 *ToValue(), base::JSONWriter::OPTIONS_PRETTY_PRINT, log);

52 }	52 }

53	53

54 } // namespace extensions	54 } // namespace extensions

OLD	NEW