extensions/common/permissions/set_disjunction_permission.h - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/permissions/set_disjunction_permission.h

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/common/permissions/set_disjunction_permission.h

diff --git a/extensions/common/permissions/set_disjunction_permission.h b/extensions/common/permissions/set_disjunction_permission.h

index 87d185886e3f94f9130fde67cc4ca80269f0a948..28b686757fe399d8974a33e432ed7545b18e9c51 100644

--- a/extensions/common/permissions/set_disjunction_permission.h

+++ b/extensions/common/permissions/set_disjunction_permission.h

@@ -122,7 +122,7 @@ class SetDisjunctionPermission : public APIPermission {

data_set_.insert(data);

} else {

std::string unknown_permission;

- base::JSONWriter::Write(item_value, &unknown_permission);

+ base::JSONWriter::Write(*item_value, &unknown_permission);

if (unhandled_permissions) {

unhandled_permissions->push_back(unknown_permission);

} else {

« no previous file with comments | « extensions/common/permissions/manifest_permission.cc ('k') | extensions/common/value_builder.cc » ('j') | no next file with comments »