content/browser/accessibility/accessibility_ui.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/accessibility_ui.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/accessibility_tree_formatter_mac.mm ('k') | content/browser/android/tracing_controller_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/accessibility_ui.cc

diff --git a/content/browser/accessibility/accessibility_ui.cc b/content/browser/accessibility/accessibility_ui.cc

index 3bfa6ee62b2bf4c2fd9583cdc318fd4db989dbba..1a466469951b2a9586bd106f6a37ba8516c165cc 100644

--- a/content/browser/accessibility/accessibility_ui.cc

+++ b/content/browser/accessibility/accessibility_ui.cc

@@ -116,14 +116,14 @@ bool HandleRequestCallback(BrowserContext* current_context,

rvh_list->Append(BuildTargetDescriptor(rvh));

}

- scoped_ptr<base::DictionaryValue> data(new base::DictionaryValue());

- data->Set("list", rvh_list.release());

- data->SetInteger(

+ base::DictionaryValue data;

+ data.Set("list", rvh_list.release());

+ data.SetInteger(

"global_a11y_mode",

BrowserAccessibilityStateImpl::GetInstance()->accessibility_mode());

std::string json_string;

- base::JSONWriter::Write(data.get(), &json_string);

+ base::JSONWriter::Write(data, &json_string);

callback.Run(base::RefCountedString::TakeString(&json_string));

return true;