Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: content/browser/android/tracing_controller_android.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: another rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/tracing_controller_android.cc
diff --git a/content/browser/android/tracing_controller_android.cc b/content/browser/android/tracing_controller_android.cc
index 6953a0de5f85015cb0334cb5d0287a3ba9031130..5c14535abf5be1975c132926aa531c1172e80be3 100644
--- a/content/browser/android/tracing_controller_android.cc
+++ b/content/browser/android/tracing_controller_android.cc
@@ -91,14 +91,14 @@ bool TracingControllerAndroid::GetKnownCategoryGroupsAsync(JNIEnv* env,
void TracingControllerAndroid::OnKnownCategoriesReceived(
const std::set<std::string>& categories_received) {
- scoped_ptr<base::ListValue> category_list(new base::ListValue());
+ base::ListValue category_list;
for (std::set<std::string>::const_iterator it = categories_received.begin();
it != categories_received.end();
++it) {
- category_list->AppendString(*it);
+ category_list.AppendString(*it);
}
std::string received_category_list;
- base::JSONWriter::Write(category_list.get(), &received_category_list);
+ base::JSONWriter::Write(category_list, &received_category_list);
// This log is required by adb_profile_chrome.py.
LOG(WARNING) << "{\"traceCategoriesList\": " << received_category_list << "}";
« no previous file with comments | « content/browser/accessibility/accessibility_ui.cc ('k') | content/browser/devtools/devtools_agent_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698