content/browser/accessibility/accessibility_tree_formatter_mac.mm - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/accessibility_tree_formatter_mac.mm

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/accessibility/accessibility_tree_formatter_mac.mm

diff --git a/content/browser/accessibility/accessibility_tree_formatter_mac.mm b/content/browser/accessibility/accessibility_tree_formatter_mac.mm

index 7b992253ee49ff75abbe182ee4376fb76001039c..b3799a9a7cde647ba17586dc11edff563fd08083 100644

--- a/content/browser/accessibility/accessibility_tree_formatter_mac.mm

+++ b/content/browser/accessibility/accessibility_tree_formatter_mac.mm

@@ -267,7 +267,7 @@ base::string16 AccessibilityTreeFormatter::ToString(

const base::Value* value;

if (dict.Get(requestedAttributeUTF8, &value)) {

std::string json_value;

- base::JSONWriter::Write(value, &json_value);

+ base::JSONWriter::Write(*value, &json_value);

WriteAttribute(

[defaultAttributes containsObject:requestedAttribute],

StringPrintf("%s=%s",

« no previous file with comments | « components/webcrypto/test/test_helpers.cc ('k') | content/browser/accessibility/accessibility_ui.cc » ('j') | no next file with comments »