components/devtools_http_handler/devtools_http_handler.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/devtools_http_handler/devtools_http_handler.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc ('k') | components/dom_distiller/core/distiller_page.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/devtools_http_handler/devtools_http_handler.cc

diff --git a/components/devtools_http_handler/devtools_http_handler.cc b/components/devtools_http_handler/devtools_http_handler.cc

index 3c9a8e77c4f6be7655be1bef58e8e015ffa94687..67c061c7cbf3eff91960876bcbf16fe29646df7f 100644

--- a/components/devtools_http_handler/devtools_http_handler.cc

+++ b/components/devtools_http_handler/devtools_http_handler.cc

@@ -813,13 +813,11 @@ void DevToolsHttpHandler::SendJson(int connection_id,

// Serialize value and message.

std::string json_value;

if (value) {

- base::JSONWriter::WriteWithOptions(value,

- base::JSONWriter::OPTIONS_PRETTY_PRINT,

- &json_value);

+ base::JSONWriter::WriteWithOptions(

+ *value, base::JSONWriter::OPTIONS_PRETTY_PRINT, &json_value);

}

std::string json_message;

- scoped_ptr<base::Value> message_object(new base::StringValue(message));

- base::JSONWriter::Write(message_object.get(), &json_message);

+ base::JSONWriter::Write(base::StringValue(message), &json_message);

net::HttpServerResponseInfo response(status_code);

response.SetBody(json_value + message, "application/json; charset=UTF-8");