components/dom_distiller/core/distiller_page.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/dom_distiller/core/distiller_page.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/devtools_http_handler/devtools_http_handler.cc ('k') | components/dom_distiller/core/page_features_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/dom_distiller/core/distiller_page.cc

diff --git a/components/dom_distiller/core/distiller_page.cc b/components/dom_distiller/core/distiller_page.cc

index 8eb6585a2acfc22120ec29a55d995a128e36ed81..74e6f1c6246ef2d5144923df0cb07bc434936902 100644

--- a/components/dom_distiller/core/distiller_page.cc

+++ b/components/dom_distiller/core/distiller_page.cc

@@ -40,7 +40,7 @@ std::string GetDistillerScriptWithOptions(

scoped_ptr<base::Value> options_value(

dom_distiller::proto::json::DomDistillerOptions::WriteToValue(options));

std::string options_json;

- if (!base::JSONWriter::Write(options_value.get(), &options_json)) {

+ if (!base::JSONWriter::Write(*options_value, &options_json)) {

NOTREACHED();

}

size_t options_offset = script.find(kOptionsPlaceholder);