components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cloud_devices/common/printer_description_unittest.cc ('k') | components/devtools_http_handler/devtools_http_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc

index d6895cd73208fcc784a84b0eab66fdf3df41f721..b80568202bb772887069c0822c874b0044323117 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc

@@ -198,7 +198,7 @@ DataReductionProxyConfigServiceClient::ConstructStaticResponse() const {

scoped_ptr<base::DictionaryValue> values(new base::DictionaryValue());

params_->PopulateConfigResponse(values.get());

request_options_->PopulateConfigResponse(values.get());

- base::JSONWriter::Write(values.get(), &response);

+ base::JSONWriter::Write(*values, &response);

return response;

}