components/autofill/core/common/save_password_progress_logger.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/save_password_progress_logger.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/common/password_form.cc ('k') | components/cloud_devices/common/cloud_device_description.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/common/save_password_progress_logger.cc

diff --git a/components/autofill/core/common/save_password_progress_logger.cc b/components/autofill/core/common/save_password_progress_logger.cc

index 2fe68c9c9c3c6768d7f5dca13fa87d1d0b9a3a3d..f6da10cf3da8fe92794787857cab349f5caf1b3a 100644

--- a/components/autofill/core/common/save_password_progress_logger.cc

+++ b/components/autofill/core/common/save_password_progress_logger.cc

@@ -143,7 +143,7 @@ void SavePasswordProgressLogger::LogMessage(

void SavePasswordProgressLogger::LogValue(StringID label, const Value& log) {

std::string log_string;

bool conversion_to_string_successful = base::JSONWriter::WriteWithOptions(

- &log, base::JSONWriter::OPTIONS_PRETTY_PRINT, &log_string);

+ log, base::JSONWriter::OPTIONS_PRETTY_PRINT, &log_string);

DCHECK(conversion_to_string_successful);

SendLog(GetStringFromID(label) + ": " + log_string);

}

« no previous file with comments | « components/autofill/core/common/password_form.cc ('k') | components/cloud_devices/common/cloud_device_description.cc » ('j') | no next file with comments »