components/cloud_devices/common/cloud_device_description.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cloud_devices/common/cloud_device_description.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/common/save_password_progress_logger.cc ('k') | components/cloud_devices/common/printer_description_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cloud_devices/common/cloud_device_description.cc

diff --git a/components/cloud_devices/common/cloud_device_description.cc b/components/cloud_devices/common/cloud_device_description.cc

index d1cb5041c8db4b38ca2dd69da0ec37c2052bebcb..ba299082b39799b7b94d02d90496d79b8c53518b 100644

--- a/components/cloud_devices/common/cloud_device_description.cc

+++ b/components/cloud_devices/common/cloud_device_description.cc

@@ -47,7 +47,7 @@ bool CloudDeviceDescription::InitFromString(const std::string& json) {

std::string CloudDeviceDescription::ToString() const {

std::string json;

base::JSONWriter::WriteWithOptions(

- root_.get(), base::JSONWriter::OPTIONS_PRETTY_PRINT, &json);

+ *root_, base::JSONWriter::OPTIONS_PRETTY_PRINT, &json);

return json;

}