components/autofill/core/common/password_form.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/password_form.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/wallet/real_pan_wallet_client.cc ('k') | components/autofill/core/common/save_password_progress_logger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/common/password_form.cc

diff --git a/components/autofill/core/common/password_form.cc b/components/autofill/core/common/password_form.cc

index 41ca1fc6c5069150568bcb8ca680b1d7d67f5309..e5edaca902396f6e61950f167ee485816173e428 100644

--- a/components/autofill/core/common/password_form.cc

+++ b/components/autofill/core/common/password_form.cc

@@ -160,7 +160,7 @@ std::ostream& operator<<(std::ostream& os, const PasswordForm& form) {

std::string form_as_string;

base::JSONWriter::WriteWithOptions(

- &form_json, base::JSONWriter::OPTIONS_PRETTY_PRINT, &form_as_string);

+ form_json, base::JSONWriter::OPTIONS_PRETTY_PRINT, &form_as_string);

base::TrimWhitespaceASCII(form_as_string, base::TRIM_ALL, &form_as_string);

return os << "PasswordForm(" << form_as_string << ")";

}