Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Unified Diff: chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: another rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc
diff --git a/chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc b/chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc
index 158caf3b034bc424ef63d6db0a2e27a3b89868d9..4a0a4b0007ec6bee271dd215ea40a49eccacc4ad 100644
--- a/chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc
+++ b/chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc
@@ -70,7 +70,7 @@ class MockSyncWebSocket : public SyncWebSocket {
base::DictionaryValue result;
result.SetInteger("param", 1);
response.Set("result", result.DeepCopy());
- base::JSONWriter::Write(&response, message);
+ base::JSONWriter::Write(response, message);
--queued_messages_;
return SyncWebSocket::kOk;
}
@@ -120,7 +120,7 @@ TEST_F(DevToolsClientImplTest, SendCommandAndGetResult) {
Status status = client.SendCommandAndGetResult("method", params, &result);
ASSERT_EQ(kOk, status.code());
std::string json;
- base::JSONWriter::Write(result.get(), &json);
+ base::JSONWriter::Write(*result, &json);
ASSERT_STREQ("{\"param\":1}", json.c_str());
}
@@ -725,7 +725,7 @@ class OnConnectedSyncWebSocket : public SyncWebSocket {
response.SetInteger("id", id);
response.Set("result", new base::DictionaryValue());
std::string json_response;
- base::JSONWriter::Write(&response, &json_response);
+ base::JSONWriter::Write(response, &json_response);
queued_response_.push_back(json_response);
// Push one event.
@@ -733,7 +733,7 @@ class OnConnectedSyncWebSocket : public SyncWebSocket {
event.SetString("method", "updateEvent");
event.Set("params", new base::DictionaryValue());
std::string json_event;
- base::JSONWriter::Write(&event, &json_event);
+ base::JSONWriter::Write(event, &json_event);
queued_response_.push_back(json_event);
return true;
« no previous file with comments | « chrome/test/chromedriver/chrome/devtools_client_impl.cc ('k') | chrome/test/chromedriver/chrome/dom_tracker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698