chrome/test/chromedriver/chrome/dom_tracker.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/dom_tracker.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc ('k') | chrome/test/chromedriver/chrome/frame_tracker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/dom_tracker.cc

diff --git a/chrome/test/chromedriver/chrome/dom_tracker.cc b/chrome/test/chromedriver/chrome/dom_tracker.cc

index 40f2f882b21150a4c53a4c2c534513f6309ed9a0..5f5fbcb5fa7f61e17493925cecad23c16de7297f 100644

--- a/chrome/test/chromedriver/chrome/dom_tracker.cc

+++ b/chrome/test/chromedriver/chrome/dom_tracker.cc

@@ -43,7 +43,7 @@ Status DomTracker::OnEvent(DevToolsClient* client,

if (!ProcessNodeList(nodes)) {

std::string json;

- base::JSONWriter::Write(nodes, &json);

+ base::JSONWriter::Write(*nodes, &json);

return Status(kUnknownError,

"DOM.setChildNodes has invalid 'nodes': " + json);

}

@@ -54,7 +54,7 @@ Status DomTracker::OnEvent(DevToolsClient* client,

if (!ProcessNode(node)) {

std::string json;

- base::JSONWriter::Write(node, &json);

+ base::JSONWriter::Write(*node, &json);

return Status(kUnknownError,

"DOM.childNodeInserted has invalid 'node': " + json);

}