chrome/test/chromedriver/chrome/devtools_client_impl.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/devtools_client_impl.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/chromedriver/chrome/console_logger.cc ('k') | chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/devtools_client_impl.cc

diff --git a/chrome/test/chromedriver/chrome/devtools_client_impl.cc b/chrome/test/chromedriver/chrome/devtools_client_impl.cc

index 4992c801253488e6765c6ac59d97bb97f185d1c6..56da77b369c29dd41c6fa9071bbbc16a7a67e137 100644

--- a/chrome/test/chromedriver/chrome/devtools_client_impl.cc

+++ b/chrome/test/chromedriver/chrome/devtools_client_impl.cc

@@ -496,7 +496,7 @@ bool ParseInspectorMessage(

if (message_dict->GetDictionary("result", &unscoped_result))

command_response->result.reset(unscoped_result->DeepCopy());

else if (message_dict->GetDictionary("error", &unscoped_error))

- base::JSONWriter::Write(unscoped_error, &command_response->error);

+ base::JSONWriter::Write(*unscoped_error, &command_response->error);

else

command_response->result.reset(new base::DictionaryValue());

return true;