chrome/browser/chromeos/policy/login_policy_test_base.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/login_policy_test_base.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/device_local_account_browsertest.cc ('k') | chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/login_policy_test_base.cc

diff --git a/chrome/browser/chromeos/policy/login_policy_test_base.cc b/chrome/browser/chromeos/policy/login_policy_test_base.cc

index 710b0bdae8a629f9ff90d67e3596d69426e63e56..7fb6adac12b75160a4d9b39c8850ab8da2bf540b 100644

--- a/chrome/browser/chromeos/policy/login_policy_test_base.cc

+++ b/chrome/browser/chromeos/policy/login_policy_test_base.cc

@@ -54,10 +54,10 @@ std::string GetPolicy(scoped_ptr<base::DictionaryValue> mandatory,

root_dict.SetString("policy_user", account);

root_dict.SetInteger("current_key_index", 0);

- std::string jsonPolicy;

+ std::string json_policy;

base::JSONWriter::WriteWithOptions(

- &root_dict, base::JSONWriter::OPTIONS_PRETTY_PRINT, &jsonPolicy);

- return jsonPolicy;

+ root_dict, base::JSONWriter::OPTIONS_PRETTY_PRINT, &json_policy);

+ return json_policy;

}

} // namespace