chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/login_policy_test_base.cc ('k') | chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc

diff --git a/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc b/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc

index ccfd6c6d4c1a28f10f92fdbcac27e3064c450998..28deddff49ddd147fe130f6740455a0c27cb423c 100644

--- a/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc

+++ b/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc

@@ -81,8 +81,8 @@ class DeviceCommandScreenshotJob::Payload

DeviceCommandScreenshotJob::Payload::Payload(ResultCode result_code) {

base::DictionaryValue root_dict;

if (result_code != SUCCESS)

- root_dict.Set(kResultFieldName, new base::FundamentalValue(result_code));

- base::JSONWriter::Write(&root_dict, &payload_);

+ root_dict.SetInteger(kResultFieldName, result_code);

+ base::JSONWriter::Write(root_dict, &payload_);

}

scoped_ptr<std::string> DeviceCommandScreenshotJob::Payload::Serialize() {