chrome/browser/chromeos/policy/device_local_account_browsertest.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/device_local_account_browsertest.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc ('k') | chrome/browser/chromeos/policy/login_policy_test_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/device_local_account_browsertest.cc

diff --git a/chrome/browser/chromeos/policy/device_local_account_browsertest.cc b/chrome/browser/chromeos/policy/device_local_account_browsertest.cc

index 108ac77af173ecab64c5902c697a230319fd2796..24509fc798a778b91476ab614da18da6382ec1fc 100644

--- a/chrome/browser/chromeos/policy/device_local_account_browsertest.cc

+++ b/chrome/browser/chromeos/policy/device_local_account_browsertest.cc

@@ -1279,7 +1279,7 @@ IN_PROC_BROWSER_TEST_F(DeviceLocalAccountTest, ExternalData) {

scoped_ptr<base::DictionaryValue> metadata =

test::ConstructExternalDataReference(kExternalDataURL, kExternalData);

std::string policy;

- base::JSONWriter::Write(metadata.get(), &policy);

+ base::JSONWriter::Write(*metadata, &policy);

device_local_account_policy_.payload().mutable_useravatarimage()->set_value(

policy);

UploadAndInstallDeviceLocalAccountPolicy();

@@ -1362,10 +1362,13 @@ IN_PROC_BROWSER_TEST_F(DeviceLocalAccountTest, UserAvatarImage) {

&image_data));

std::string policy;

- base::JSONWriter::Write(test::ConstructExternalDataReference(

- embedded_test_server()->GetURL(std::string("/") +

- chromeos::test::kUserAvatarImage1RelativePath).spec(),

- image_data).get(),

+ base::JSONWriter::Write(

+ *test::ConstructExternalDataReference(

+ embedded_test_server()

+ ->GetURL(std::string("/") +

+ chromeos::test::kUserAvatarImage1RelativePath)

+ .spec(),

+ image_data),

&policy);

device_local_account_policy_.payload().mutable_useravatarimage()->set_value(

policy);