chrome/browser/chromeos/file_manager/url_util_unittest.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_manager/url_util_unittest.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/file_manager/url_util.cc ('k') | chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/file_manager/url_util_unittest.cc

diff --git a/chrome/browser/chromeos/file_manager/url_util_unittest.cc b/chrome/browser/chromeos/file_manager/url_util_unittest.cc

index 1360d0016a8d2f5252903b5444442d1b6245f0b3..569617dc2d64908384bd385a865ebfe0ead4549f 100644

--- a/chrome/browser/chromeos/file_manager/url_util_unittest.cc

+++ b/chrome/browser/chromeos/file_manager/url_util_unittest.cc

@@ -23,9 +23,8 @@ std::string PrettyPrintEscapedJson(const std::string& query) {

query, net::UnescapeRule::SPACES | net::UnescapeRule::URL_SPECIAL_CHARS);

scoped_ptr<base::Value> value(base::JSONReader::Read(json));

std::string pretty_json;

- base::JSONWriter::WriteWithOptions(value.get(),

- base::JSONWriter::OPTIONS_PRETTY_PRINT,

- &pretty_json);

+ base::JSONWriter::WriteWithOptions(

+ *value, base::JSONWriter::OPTIONS_PRETTY_PRINT, &pretty_json);

return pretty_json;

}