chrome/browser/chromeos/file_manager/url_util.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_manager/url_util.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/file_manager/file_manager_browsertest.cc ('k') | chrome/browser/chromeos/file_manager/url_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/file_manager/url_util.cc

diff --git a/chrome/browser/chromeos/file_manager/url_util.cc b/chrome/browser/chromeos/file_manager/url_util.cc

index 088751b5c477c04792da35107164ae2bd785e86c..1f3e9d8674c8ad3bfb735bfd6bd0d21a03496391 100644

--- a/chrome/browser/chromeos/file_manager/url_util.cc

+++ b/chrome/browser/chromeos/file_manager/url_util.cc

@@ -111,7 +111,7 @@ GURL GetFileManagerMainPageUrlWithParams(

!file_types || !file_types->support_drive);

std::string json_args;

- base::JSONWriter::Write(&arg_value, &json_args);

+ base::JSONWriter::Write(arg_value, &json_args);

std::string url = GetFileManagerMainPageUrl().spec() + '?' +

net::EscapeUrlEncodedData(json_args,