chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc - Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc

Issue 1131113004: Convert JsonWriter::Write to taking a const ref for the in-param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/file_manager/url_util_unittest.cc ('k') | chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_policy_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc

diff --git a/chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc b/chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc

index b3542385c31fcb2bf4a240b5ceee9568e3921106..63cab01538ae55b18f212b2fa643f62352104895 100644

--- a/chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc

+++ b/chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc

@@ -656,10 +656,12 @@ class UserImageManagerPolicyTest : public UserImageManagerTest,

ADD_FAILURE();

}

std::string policy;

- base::JSONWriter::Write(policy::test::ConstructExternalDataReference(

- embedded_test_server()->GetURL(std::string("/") + relative_path).spec(),

- image_data).get(),

- &policy);

+ base::JSONWriter::Write(*policy::test::ConstructExternalDataReference(

+ embedded_test_server()

+ ->GetURL(std::string("/") + relative_path)

+ .spec(),

+ image_data),

+ &policy);

return policy;

}