Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 1131083004: Fix loadUrl for javascript urls. (Closed)

Created:
5 years, 7 months ago by gsennton
Modified:
5 years, 7 months ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix loadUrl for javascript urls. A recent update https://codereview.chromium.org/1022993002 broke the loading of javascript URLs. This patch reverts only the part of the update which is broken. BUG=489259 Committed: https://crrev.com/1649ce638403abeb04c03d219221af7dc2817e57 Cr-Commit-Position: refs/heads/master@{#330507}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
gsennton
5 years, 7 months ago (2015-05-19 10:49:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131083004/1
5 years, 7 months ago (2015-05-19 10:53:14 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 7 months ago (2015-05-19 10:53:16 UTC) #6
Torne
lgtm
5 years, 7 months ago (2015-05-19 11:20:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131083004/1
5 years, 7 months ago (2015-05-19 11:20:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 11:54:15 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 11:56:12 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1649ce638403abeb04c03d219221af7dc2817e57
Cr-Commit-Position: refs/heads/master@{#330507}

Powered by Google App Engine
This is Rietveld 408576698