Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 1022993002: Add debug logging for calls into AwContents (Closed)

Created:
5 years, 9 months ago by boliu
Modified:
5 years, 9 months ago
Reviewers:
sgurun-gerrit only
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add debug logging for calls into AwContents These mostly match what's currently available in WebView class itself. The implementation in WebView will be removed. BUG= Committed: https://crrev.com/27532a0085a0a6b1ba34ca6753c60f1781de8734 Cr-Commit-Position: refs/heads/master@{#321452}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -1 line) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 42 chunks +48 lines, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwSettings.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
boliu
ptal other side ag/659755
5 years, 9 months ago (2015-03-19 21:24:54 UTC) #2
sgurun-gerrit only
lgtm
5 years, 9 months ago (2015-03-19 21:58:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022993002/1
5 years, 9 months ago (2015-03-19 21:59:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 22:31:31 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 22:32:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27532a0085a0a6b1ba34ca6753c60f1781de8734
Cr-Commit-Position: refs/heads/master@{#321452}

Powered by Google App Engine
This is Rietveld 408576698