Merge gesture deletion and selection.

Merge gesture deletion and selection.

BUG=

Committed: https://crrev.com/ecb5ce9e46448cc06b2fc0735eff55129a0d3969
Cr-Commit-Position: refs/heads/master@{#329416}

[rsadam, 2015-05-11 15:57:39]

rsadam@chromium.org changed reviewers:
+ bshe@chromium.org

[rsadam, 2015-05-11 15:57:40]

Also disables it by default since it was punted to M45.

PTAL, Biao!

[rsadam, 2015-05-11 16:34:43]

rsadam@chromium.org changed reviewers:
+ asvitkine@chromium.org

[rsadam, 2015-05-11 16:34:44]

asvitkine@chromium.org: Please review changes in histograms.xml

[Alexei Svitkine (slow), 2015-05-11 21:07:58]

lgtm

[bshe, 2015-05-12 14:58:59]

lgtm

Do we have a crbug to refer to this change? If not, it is OK. If yes, please
link the bug number in the description.

https://codereview.chromium.org/1130833005/diff/40001/ui/keyboard/keyboard_sw...
File ui/keyboard/keyboard_switches.h (right):

https://codereview.chromium.org/1130833005/diff/40001/ui/keyboard/keyboard_sw...
ui/keyboard/keyboard_switches.h:42: // Gesture editing for the virtual keyboard.
nit: It would be easier to read if you could specify this controls the gesture
editing settings for the virtual keyboard.

https://codereview.chromium.org/1130833005/diff/40001/ui/keyboard/keyboard_ut...
File ui/keyboard/keyboard_util.h (right):

https://codereview.chromium.org/1130833005/diff/40001/ui/keyboard/keyboard_ut...
ui/keyboard/keyboard_util.h:102: // Returns true if gesture deletion is enabled
for virtual keyboard.
nit: s/deletion/editing in settings

[rsadam, 2015-05-12 15:16:05]

> Do we have a crbug to refer to this change? If not, it is OK. If yes, please
> link the bug number in the description.

It was a simple enough change, so I didn't file a bug for it. Should I do so in
future?

[rsadam, 2015-05-12 15:16:15]

https://codereview.chromium.org/1130833005/diff/40001/ui/keyboard/keyboard_sw...
File ui/keyboard/keyboard_switches.h (right):

https://codereview.chromium.org/1130833005/diff/40001/ui/keyboard/keyboard_sw...
ui/keyboard/keyboard_switches.h:42: // Gesture editing for the virtual keyboard.
On 2015/05/12 14:58:59, bshe wrote:
> nit: It would be easier to read if you could specify this controls the gesture
> editing settings for the virtual keyboard.

Done.

https://codereview.chromium.org/1130833005/diff/40001/ui/keyboard/keyboard_ut...
File ui/keyboard/keyboard_util.h (right):

https://codereview.chromium.org/1130833005/diff/40001/ui/keyboard/keyboard_ut...
ui/keyboard/keyboard_util.h:102: // Returns true if gesture deletion is enabled
for virtual keyboard.
On 2015/05/12 14:58:59, bshe wrote:
> nit: s/deletion/editing in settings

Done.

[rsadam, 2015-05-12 15:16:32]

The CQ bit was checked by rsadam@chromium.org

[rsadam, 2015-05-12 15:16:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org, bshe@chromium.org
Link to the patchset: https://codereview.chromium.org/1130833005/#ps60001
(title: "Address feedback")

[commit-bot: I haz the power, 2015-05-12 15:17:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1130833005/60001

[bshe, 2015-05-12 15:31:46]

On 2015/05/12 15:16:05, rsadam wrote:
> > Do we have a crbug to refer to this change? If not, it is OK. If yes, please
> > link the bug number in the description.
> 
> It was a simple enough change, so I didn't file a bug for it. Should I do so
in
> future?

Would be nice to have a bug to give some background on why we want to
merge the two flags. But as you said it is simple enough so it is up to you. The
rule
is not enforced.

[commit-bot: I haz the power, 2015-05-12 16:25:00]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-05-12 16:25:53]

Patchset 4 (id:??) landed as
https://crrev.com/ecb5ce9e46448cc06b2fc0735eff55129a0d3969
Cr-Commit-Position: refs/heads/master@{#329416}