Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc

Issue 1130833005: Merge gesture deletion and selection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_ keyboard_delegate.h" 5 #include "chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_ keyboard_delegate.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/metrics/histogram.h" 10 #include "base/metrics/histogram.h"
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 base::DictionaryValue* results) { 57 base::DictionaryValue* results) {
58 DCHECK_CURRENTLY_ON(content::BrowserThread::UI); 58 DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
59 results->SetString("layout", keyboard::GetKeyboardLayout()); 59 results->SetString("layout", keyboard::GetKeyboardLayout());
60 results->SetBoolean("a11ymode", keyboard::GetAccessibilityKeyboardEnabled()); 60 results->SetBoolean("a11ymode", keyboard::GetAccessibilityKeyboardEnabled());
61 scoped_ptr<base::ListValue> features(new base::ListValue()); 61 scoped_ptr<base::ListValue> features(new base::ListValue());
62 features->AppendString(GenerateFeatureFlag( 62 features->AppendString(GenerateFeatureFlag(
63 "floatingvirtualkeyboard", keyboard::IsFloatingVirtualKeyboardEnabled())); 63 "floatingvirtualkeyboard", keyboard::IsFloatingVirtualKeyboardEnabled()));
64 features->AppendString( 64 features->AppendString(
65 GenerateFeatureFlag("gesturetyping", keyboard::IsGestureTypingEnabled())); 65 GenerateFeatureFlag("gesturetyping", keyboard::IsGestureTypingEnabled()));
66 features->AppendString(GenerateFeatureFlag( 66 features->AppendString(GenerateFeatureFlag(
67 "gestureselection", keyboard::IsGestureSelectionEnabled())); 67 "gestureediting", keyboard::IsGestureEditingEnabled()));
68 features->AppendString(GenerateFeatureFlag(
69 "gesturedeletion", keyboard::IsGestureDeletionEnabled()));
70 features->AppendString(GenerateFeatureFlag( 68 features->AppendString(GenerateFeatureFlag(
71 "materialdesign", keyboard::IsMaterialDesignEnabled())); 69 "materialdesign", keyboard::IsMaterialDesignEnabled()));
72 features->AppendString( 70 features->AppendString(
73 GenerateFeatureFlag("voiceinput", keyboard::IsVoiceInputEnabled())); 71 GenerateFeatureFlag("voiceinput", keyboard::IsVoiceInputEnabled()));
74 features->AppendString(GenerateFeatureFlag("experimental", 72 features->AppendString(GenerateFeatureFlag("experimental",
75 keyboard::IsExperimentalInputViewEnabled())); 73 keyboard::IsExperimentalInputViewEnabled()));
76 results->Set("features", features.Pass()); 74 results->Set("features", features.Pass());
77 return true; 75 return true;
78 } 76 }
79 77
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 } 163 }
166 164
167 bool ChromeVirtualKeyboardDelegate::IsLanguageSettingsEnabled() { 165 bool ChromeVirtualKeyboardDelegate::IsLanguageSettingsEnabled() {
168 return (user_manager::UserManager::Get()->IsUserLoggedIn() && 166 return (user_manager::UserManager::Get()->IsUserLoggedIn() &&
169 !chromeos::UserAddingScreen::Get()->IsRunning() && 167 !chromeos::UserAddingScreen::Get()->IsRunning() &&
170 !(chromeos::ScreenLocker::default_screen_locker() && 168 !(chromeos::ScreenLocker::default_screen_locker() &&
171 chromeos::ScreenLocker::default_screen_locker()->locked())); 169 chromeos::ScreenLocker::default_screen_locker()->locked()));
172 } 170 }
173 171
174 } // namespace extensions 172 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698