chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc - Issue 1130833005: Merge gesture deletion and selection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc

Issue 1130833005: Merge gesture deletion and selection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc

diff --git a/chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc b/chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc

index 3fe29f2f282e3992afffed4b21d55003e4afb3e9..0c859235b15ad1cdac5001f3f8e2adedd218cc3d 100644

--- a/chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc

+++ b/chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc

@@ -64,9 +64,7 @@ bool ChromeVirtualKeyboardDelegate::GetKeyboardConfig(

features->AppendString(

GenerateFeatureFlag("gesturetyping", keyboard::IsGestureTypingEnabled()));

features->AppendString(GenerateFeatureFlag(

- "gestureselection", keyboard::IsGestureSelectionEnabled()));

- features->AppendString(GenerateFeatureFlag(

- "gesturedeletion", keyboard::IsGestureDeletionEnabled()));

+ "gestureediting", keyboard::IsGestureEditingEnabled()));

features->AppendString(GenerateFeatureFlag(

"materialdesign", keyboard::IsMaterialDesignEnabled()));

features->AppendString(

« no previous file with comments | « chrome/browser/about_flags.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »