Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1001)

Issue 11308295: Revert 170483 - Remove PrefObserver usages, batch 12. (Closed)

Created:
8 years ago by Jói
Modified:
8 years ago
Reviewers:
Jói
CC:
chromium-reviews, sadrul, sail+watch_chromium.org, ben+watch_chromium.org
Visibility:
Public.

Description

Revert 170483 - Remove PrefObserver usages, batch 12. TBR=ben@chromium.org BUG=155525 Review URL: https://chromiumcodereview.appspot.com/11280115 Reason for revert: A review comment after commit showed that the change is probably wrong (or at least changes behavior in a way that was not intended). Reverting for now, until there is time to figure out the correct change. TBR=joi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170519

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -114 lines) Patch
MM chrome/browser/ui/alternate_error_tab_observer.h View 3 chunks +7 lines, -3 lines 0 comments Download
MM chrome/browser/ui/alternate_error_tab_observer.cc View 3 chunks +12 lines, -9 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.h View 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.cc View 4 chunks +19 lines, -21 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.h View 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc View 4 chunks +19 lines, -23 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.h View 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 3 chunks +33 lines, -36 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.h View 4 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h View 4 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Jói
8 years ago (2012-11-30 20:07:13 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698