Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2891)

Unified Diff: chrome/browser/ui/alternate_error_tab_observer.h

Issue 11308295: Revert 170483 - Remove PrefObserver usages, batch 12. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/alternate_error_tab_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/alternate_error_tab_observer.h
===================================================================
--- chrome/browser/ui/alternate_error_tab_observer.h (revision 170518)
+++ chrome/browser/ui/alternate_error_tab_observer.h (working copy)
@@ -6,6 +6,7 @@
#define CHROME_BROWSER_UI_ALTERNATE_ERROR_TAB_OBSERVER_H_
#include "base/prefs/public/pref_change_registrar.h"
+#include "base/prefs/public/pref_observer.h"
#include "chrome/browser/prefs/pref_service.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
@@ -18,7 +19,8 @@
class AlternateErrorPageTabObserver
: public content::WebContentsObserver,
public content::NotificationObserver,
- public content::WebContentsUserData<AlternateErrorPageTabObserver> {
+ public content::WebContentsUserData<AlternateErrorPageTabObserver>,
+ public PrefObserver {
public:
virtual ~AlternateErrorPageTabObserver();
@@ -37,14 +39,16 @@
const content::NotificationSource& source,
const content::NotificationDetails& details) OVERRIDE;
+ // PrefObserver overrides:
+ virtual void OnPreferenceChanged(PrefServiceBase* service,
+ const std::string& pref_name) OVERRIDE;
+
// Internal helpers ----------------------------------------------------------
// Returns the server that can provide alternate error pages. If the returned
// URL is empty, the default error page built into WebKit will be used.
GURL GetAlternateErrorPageURL() const;
- void OnAlternateErrorPagesEnabledChanged();
-
// Send the alternate error page URL to the renderer.
void UpdateAlternateErrorPageURL(content::RenderViewHost* rvh);
Property changes on: chrome/browser/ui/alternate_error_tab_observer.h
___________________________________________________________________
Deleted: svn:mergeinfo
« no previous file with comments | « no previous file | chrome/browser/ui/alternate_error_tab_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698