Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7328)

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 11308295: Revert 170483 - Remove PrefObserver usages, batch 12. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm
===================================================================
--- chrome/browser/ui/cocoa/browser_window_cocoa.mm (revision 170518)
+++ chrome/browser/ui/cocoa/browser_window_cocoa.mm (working copy)
@@ -89,10 +89,7 @@
attention_request_id_(0) {
pref_change_registrar_.Init(browser_->profile()->GetPrefs());
- pref_change_registrar_.Add(
- prefs::kShowBookmarkBar,
- base::Bind(&BrowserWindowCocoa::OnShowBookmarkBarChanged,
- base::Unretained(this)));
+ pref_change_registrar_.Add(prefs::kShowBookmarkBar, this);
gfx::Rect bounds;
chrome::GetSavedWindowBoundsAndShowState(browser_,
&bounds,
@@ -617,7 +614,9 @@
return false;
}
-void BrowserWindowCocoa::OnShowBookmarkBarChanged() {
+void BrowserWindowCocoa::OnPreferenceChanged(PrefServiceBase* service,
+ const std::string& pref_name) {
+ DCHECK(pref_name == prefs::kShowBookmarkBar);
[controller_ updateBookmarkBarVisibilityWithAnimation:YES];
}
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_cocoa.h ('k') | chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698