Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11308130: Rename onSuccess to onComplete in HttpRequest. (Closed)

Created:
8 years, 1 month ago by Emily Fortuna
Modified:
8 years, 1 month ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Rename onSuccess to onComplete in HttpRequest. BUG= Committed: https://code.google.com/p/dart/source/detail?r=15180

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -20 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +10 lines, -8 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M sdk/lib/html/templates/html/dart2js/factoryprovider_HttpRequest.darttemplate View 1 chunk +4 lines, -4 lines 2 comments Download
M sdk/lib/html/templates/html/impl/impl_HttpRequest.darttemplate View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Emily Fortuna
8 years, 1 month ago (2012-11-20 20:47:48 UTC) #1
blois
https://codereview.chromium.org/11308130/diff/1/sdk/lib/html/templates/html/dart2js/factoryprovider_HttpRequest.darttemplate File sdk/lib/html/templates/html/dart2js/factoryprovider_HttpRequest.darttemplate (right): https://codereview.chromium.org/11308130/diff/1/sdk/lib/html/templates/html/dart2js/factoryprovider_HttpRequest.darttemplate#newcode12 sdk/lib/html/templates/html/dart2js/factoryprovider_HttpRequest.darttemplate:12: onComplete(HttpRequest request)) => Can we just get rid of ...
8 years, 1 month ago (2012-11-20 20:49:26 UTC) #2
Emily Fortuna
https://codereview.chromium.org/11308130/diff/1/sdk/lib/html/templates/html/dart2js/factoryprovider_HttpRequest.darttemplate File sdk/lib/html/templates/html/dart2js/factoryprovider_HttpRequest.darttemplate (right): https://codereview.chromium.org/11308130/diff/1/sdk/lib/html/templates/html/dart2js/factoryprovider_HttpRequest.darttemplate#newcode12 sdk/lib/html/templates/html/dart2js/factoryprovider_HttpRequest.darttemplate:12: onComplete(HttpRequest request)) => On 2012/11/20 20:49:27, blois wrote: > ...
8 years, 1 month ago (2012-11-20 21:10:10 UTC) #3
blois
8 years, 1 month ago (2012-11-20 21:21:28 UTC) #4 
lgtm

Don't worry about it then.

Powered by Google App Engine
This is Rietveld 408576698