Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: sdk/lib/html/templates/html/dart2js/factoryprovider_HttpRequest.darttemplate

Issue 11308130: Rename onSuccess to onComplete in HttpRequest. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/html/templates/html/dart2js/factoryprovider_HttpRequest.darttemplate
diff --git a/sdk/lib/html/templates/html/dart2js/factoryprovider_HttpRequest.darttemplate b/sdk/lib/html/templates/html/dart2js/factoryprovider_HttpRequest.darttemplate
index c1acc88bd3c6a956c064bad72bf7203fb9494249..a739f36512b0568a1257a65d24a36d31dbfc8f0e 100644
--- a/sdk/lib/html/templates/html/dart2js/factoryprovider_HttpRequest.darttemplate
+++ b/sdk/lib/html/templates/html/dart2js/factoryprovider_HttpRequest.darttemplate
@@ -9,10 +9,10 @@ class $FACTORYPROVIDER {
JS('HttpRequest', 'new XMLHttpRequest()');
static HttpRequest createHttpRequest_get(String url,
- onSuccess(HttpRequest request)) =>
- _HttpRequestUtils.get(url, onSuccess, false);
+ onComplete(HttpRequest request)) =>
blois 2012/11/20 20:49:27 Can we just get rid of this file?
Emily Fortuna 2012/11/20 21:10:11 It requires changing the logic in generator.py so
+ _HttpRequestUtils.get(url, onComplete, false);
static HttpRequest createHttpRequest_getWithCredentials(String url,
- onSuccess(HttpRequest request)) =>
- _HttpRequestUtils.get(url, onSuccess, true);
+ onComplete(HttpRequest request)) =>
+ _HttpRequestUtils.get(url, onComplete, true);
}
« no previous file with comments | « sdk/lib/html/dartium/html_dartium.dart ('k') | sdk/lib/html/templates/html/impl/impl_HttpRequest.darttemplate » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698