sdk/lib/html/dartium/html_dartium.dart - Issue 11308130: Rename onSuccess to onComplete in HttpRequest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Side-by-side diff isn't available for this file because of its large size.

Issue 11308130: Rename onSuccess to onComplete in HttpRequest. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/html/dartium/html_dartium.dart

diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart

index 30ea8b93349268176c75030ecbca4d3408110daf..7d30a67fcd2e2c8fb91213d1a74198f79911f282 100644

--- a/sdk/lib/html/dartium/html_dartium.dart

+++ b/sdk/lib/html/dartium/html_dartium.dart

@@ -12446,11 +12446,13 @@ class HtmlElement extends _Element_Merged {

class HttpRequest extends EventTarget {

- factory HttpRequest.get(String url, onSuccess(HttpRequest request)) =>

- _HttpRequestFactoryProvider.createHttpRequest_get(url, onSuccess);

+ factory HttpRequest.get(String url, onComplete(HttpRequest request)) =>

+ _HttpRequestFactoryProvider.createHttpRequest_get(url, onComplete);

- factory HttpRequest.getWithCredentials(String url, onSuccess(HttpRequest request)) =>

- _HttpRequestFactoryProvider.createHttpRequest_getWithCredentials(url, onSuccess);

+ factory HttpRequest.getWithCredentials(String url,

+ onComplete(HttpRequest request)) =>

+ _HttpRequestFactoryProvider.createHttpRequest_getWithCredentials(url,

+ onComplete);

factory HttpRequest() => _HttpRequestFactoryProvider.createHttpRequest();