Chromium Code Reviews
Help | Chromium Project | Sign in
(883)

Issue 11308012: Remove some TabContentses from extensions. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by Avi
Modified:
1 year, 5 months ago
CC:
chromium-reviews_chromium.org, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org
Visibility:
Public.

Description

Remove some TabContentses from extensions.

This is a removal from ExtensionTabUtil and then following dependencies.

BUG=107201
TEST=no visible change


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164963

Patch Set 1 #

Patch Set 2 : rebase, android #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -158 lines) Lint Patch
M chrome/browser/accessibility/accessibility_extension_api.cc View 3 chunks +2 lines, -3 lines 0 comments 0 errors Download
M chrome/browser/extensions/api/debugger/debugger_api.h View 1 chunk +1 line, -1 line 0 comments 0 errors Download
M chrome/browser/extensions/api/debugger/debugger_api.cc View 4 chunks +8 lines, -9 lines 0 comments 0 errors Download
M chrome/browser/extensions/api/extension_action/extension_actions_api.h View 2 chunks +7 lines, -3 lines 0 comments ? errors Download
M chrome/browser/extensions/api/extension_action/extension_actions_api.cc View 4 chunks +3 lines, -4 lines 0 comments ? errors Download
M chrome/browser/extensions/api/extension_action/extension_page_actions_api.cc View 4 chunks +4 lines, -6 lines 0 comments 0 errors Download
M chrome/browser/extensions/api/messaging/message_service.cc View 2 chunks +4 lines, -5 lines 0 comments ? errors Download
M chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.h View 1 chunk +2 lines, -2 lines 0 comments 0 errors Download
M chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc View 2 chunks +2 lines, -3 lines 0 comments 0 errors Download
M chrome/browser/extensions/api/page_capture/page_capture_api.cc View 2 chunks +3 lines, -4 lines 0 comments 0 errors Download
M chrome/browser/extensions/api/processes/processes_api.cc View 3 chunks +2 lines, -3 lines 0 comments ? errors Download
M chrome/browser/extensions/api/tabs/execute_code_in_tab_function.cc View 6 chunks +10 lines, -12 lines 0 comments 0 errors Download
M chrome/browser/extensions/api/tabs/tabs.h View 2 chunks +1 line, -2 lines 0 comments ? errors Download
M chrome/browser/extensions/api/tabs/tabs.cc View 27 chunks +44 lines, -53 lines 0 comments ? errors Download
M chrome/browser/extensions/api/web_navigation/web_navigation_api.cc View 2 chunks +6 lines, -8 lines 0 comments ? errors Download
M chrome/browser/extensions/browser_event_router.h View 1 chunk +1 line, -1 line 0 comments 0 errors Download
M chrome/browser/extensions/browser_event_router.cc View 7 chunks +15 lines, -17 lines 0 comments ? errors Download
M chrome/browser/extensions/extension_devtools_bridge.cc View 1 chunk +2 lines, -2 lines 0 comments ? errors Download
M chrome/browser/extensions/extension_tab_util.h View 2 chunks +2 lines, -3 lines 0 comments 0 errors Download
M chrome/browser/extensions/extension_tab_util.cc View 4 chunks +10 lines, -11 lines 0 comments 0 errors Download
M chrome/browser/extensions/extension_tab_util_android.cc View 1 2 chunks +2 lines, -2 lines 0 comments 0 errors Download
M chrome/browser/infobars/infobar_extension_api.cc View 3 chunks +3 lines, -4 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 9
Avi
1 year, 5 months ago #1
Aaron Boodman
lgtm
1 year, 5 months ago #2
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11308012/8001
1 year, 5 months ago #3
I haz the power (commit-bot)
Presubmit check for 11308012-8001 failed and returned exit status 1. Running presubmit commit checks ...
1 year, 5 months ago #4
Avi
Ben, owner review.
1 year, 5 months ago #5
Ben Goodger (Google)
lgtm
1 year, 5 months ago #6
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11308012/8001
1 year, 5 months ago #7
dmazzoni
lgtm
1 year, 5 months ago #8
I haz the power (commit-bot)
1 year, 5 months ago #9
Change committed as 164963
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6