Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5038)

Unified Diff: chrome/browser/extensions/api/extension_action/extension_actions_api.cc

Issue 11308012: Remove some TabContentses from extensions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/extension_action/extension_actions_api.cc
diff --git a/chrome/browser/extensions/api/extension_action/extension_actions_api.cc b/chrome/browser/extensions/api/extension_action/extension_actions_api.cc
index 3b7a2b496747281dec1cf95d8f53e664872284a6..b741308da593940ccf540472193ef668a2f0fbe8 100644
--- a/chrome/browser/extensions/api/extension_action/extension_actions_api.cc
+++ b/chrome/browser/extensions/api/extension_action/extension_actions_api.cc
@@ -20,7 +20,6 @@
#include "chrome/browser/extensions/state_store.h"
#include "chrome/browser/extensions/tab_helper.h"
#include "chrome/browser/profiles/profile.h"
-#include "chrome/browser/ui/tab_contents/tab_contents.h"
#include "chrome/common/chrome_notification_types.h"
#include "chrome/common/extensions/extension.h"
#include "chrome/common/extensions/extension_error_utils.h"
@@ -343,7 +342,7 @@ bool ExtensionActionFunction::RunImpl() {
}
}
- // Find the TabContents that contains this tab id if one is required.
+ // Find the WebContents that contains this tab id if one is required.
if (tab_id_ == ExtensionAction::kDefaultTabId) {
EXTENSION_FUNCTION_VALIDATE(
extensions::ExtensionActionManager::Get(profile_)->
@@ -388,7 +387,7 @@ void ExtensionActionFunction::NotifyBrowserActionChange() {
}
void ExtensionActionFunction::NotifyLocationBarChange() {
- extensions::TabHelper::FromWebContents(contents_->web_contents())->
+ extensions::TabHelper::FromWebContents(contents_)->
location_bar_controller()->NotifyChange();
}
@@ -438,7 +437,7 @@ bool ExtensionActionFunction::SetVisible(bool visible) {
extensions::TabHelper& ExtensionActionFunction::tab_helper() const {
CHECK(contents_);
- return *extensions::TabHelper::FromWebContents(contents_->web_contents());
+ return *extensions::TabHelper::FromWebContents(contents_);
}
bool ExtensionActionShowFunction::RunExtensionAction() {

Powered by Google App Engine
This is Rietveld 408576698